the-kenny / weechat.el

Chat via weechat's relay protocol in Emacs
177 stars 42 forks source link

Make it possible to receive notifications on all messages -- not just mentions -- for certain channels #67

Open ahmedalsudani opened 6 years ago

ahmedalsudani commented 6 years ago

Thanks for creating weechat.el! It's been a great boon to me.

One thing I find useful is notifications for all messages in the channels that I own.

My plan is to make this change for my own use, but if you think this is valuable, I will make my changes look nicer so they can be merged here.

Would you merge it if it were another defcustom that allowed users to specify "always notify" buffers?

the-kenny commented 6 years ago

Hi Ahmed,

I'm glad you like weechat.el! It has some shortcomings, but it's pretty flexible in most cases.

Allowing users to specify "always notify" for a list of buffers sounds quite useful, I'd be glad to merge a change like this into weechat.el.

Maybe you can extend weechat-notification-types similar to weechat-tracking-types and allow a cons of (regex . message-type) where regex must match the buffer-name and message-type would act as a filter (:highlight, :message) for notifications to trigger.

This would allow users to customize the notification-level on a pretty flexible per-buffer or even per-network level.

If you need any pointers feel free to ping me. Also, feel free to try something else - there's no guarantee my idea is good ;-)

Ahmed Al-Sudani notifications@github.com writes:

Thanks for creating weechat.el! It's been a great boon to me.

One thing I find useful is notifications for all messages in the channels that I own.

My plan is to make this change for my own use, but if you think this is valuable, I will make my changes look nicer so they can be merged here.

Would you merge it if it were another defcustom that allowed users to specify "always notify" buffers?

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/the-kenny/weechat.el/issues/67