search

the-lambda-church / dmlenu

a clone of dmenu written in OCaml.
MIT License
46 stars 5 forks source link

Fix `examples/with_subcommand` #17

Closed co-dan closed 4 years ago

co-dan commented 4 years ago

Lazy binaries introduced in d0681973028b0fef47d3f5820412dfb0ec343882 breaks that example.

(tested with OCaml 4.08.0)

co-dan commented 4 years ago

Oops, looks like I push more commits than intended. 49748ff resolves the problem with examples/with_subcommand.ml

362d08a resolves a different issue: if you run dmlenu and select some options with arrow keys and press enter, then it doesn't actually register the selection. this commit fixes it.

should i open a separate pull request for that?

trefis commented 4 years ago

should i open a separate pull request for that?

Nope, no need.

Thanks!

co-dan commented 4 years ago

Great! In my repo (https://github.com/co-dan/dmlenu/tree/wmctrl_util) I also have some patches for controlling the border around the window. Are you interested in adding support for that?