the-library-code / dspace-rest-python

DSpace REST API Client Library
BSD 3-Clause "New" or "Revised" License
24 stars 19 forks source link

Refactor camelCase to lowercase_underscored? #19

Open kshepherd opened 3 weeks ago

kshepherd commented 3 weeks ago

I used camelCase to more closely mirror the REST API JSON, but it's generally not considered good/proper Python naming convention, and it should be possible to parse/format to and from each anyway...

So I think we should change all our camelCase class member variable names, e.g. shortDescription -> short_description in the Python objects themselves... then, what about the dict? Or do we just rewrite the dict back to camelCase just before doing a POST or PUT?

(I'm not convinced it's worth it, so leaving this issue open for input from others - it would be a breaking change for a major release in the future)