the-library-code / dspace-rest-python

DSpace REST API Client Library
BSD 3-Clause "New" or "Revised" License
25 stars 21 forks source link

setuptools dependency missing #22

Open misilot opened 2 weeks ago

misilot commented 2 weeks ago

I had to install setuptools to get this to run

kshepherd commented 2 weeks ago

thanks @misilot - setuptools is in requirements.txt -- what version were you installing? did you run pip install -r requirements.txt ?

misilot commented 2 weeks ago

Hmm, nope I missed that part. I just did poetry add dspace-rest-python.

kshepherd commented 2 weeks ago

@misilot i'll try that out - pip install dspace-rest-python works afaik so i'll see if i need to add anything more for poetry

alanorth commented 6 days ago

@misilot I'm surprised that you needed setuptools. Nothing in this code explicitly imports that, and I thought it was rather something that was supposed to be provided by whatever manages your virtualenv. I used this briefly with pipenv and didn't need to explicitly install setuptools.