search

the-linux-schools-project / karoshi-client

Central repository for Karoshi Client development
http://linuxschools.org.uk
5 stars 6 forks source link

Thunderbird profile lockdown #115

Closed RobinMcCorkell closed 9 years ago

RobinMcCorkell commented 9 years ago

Same thing as #106, just for Thunderbird. Also removed the first run notices and splash screens for Firetray, Omnibar and Zotero.

Please review @Eldara98

Eldara98 commented 9 years ago

Generally LGTM, but I thought leaving the first run pages in was in the interest of improving UX? Seeing as the profiles are now uploaded, does it really matter if users see the first run pages?

RobinMcCorkell commented 9 years ago

@Eldara98 The problem is, these are extensions that should be transparent to the user. A user shouldn't see the first run page for Firetray: they don't care about it. Likewise for Omnibar. I thought about leaving the Zotero first run page in, since that is the only relevant extension, but the way it does it is a bit obtrusive IMHO. I think the drop down notification 'Press here to open Zotero' is sufficient.

RobinMcCorkell commented 9 years ago

@Eldara98 Please review that last commit. Thanks!

RobinMcCorkell commented 9 years ago

OK, I've thoroughly tested the changes, and everything is working OK. Just waiting on your review @Eldara98 !:shipit:

Eldara98 commented 9 years ago

LGTM :+1: