search

the-machine-project / the-machine

Welcome to the machine...
http://www.themachineproject.org
76 stars 25 forks source link

MainPage multi platform opencv loading #29

Closed xnart closed 8 years ago

xnart commented 8 years ago

It doesn't cover all platforms but should be enough to initial shift for multi platform support.

Also i changed package name because the project's domain is "machineproject.org" so "org.machineproject.machine" is best fit for that. For more information : https://maven.apache.org/guides/mini/guide-naming-conventions.html

Edit : Looks like i messed up with project url. It should be themachineproject.org

devloop0 commented 8 years ago

Quick question, here: https://github.com/xnart/the-machine/blob/master/src/main/java/org/machineproject/machine/MainPage.java#L30, if you're on Linux, it seems to be loading ./ASSETS/lib/x64/opencv_java310.so, I'm assuming that exists on your local machine. I'm assuming when packaging it, we will have to either modify the path or add the .so file at that directory, right? Other than that, it looks pretty good, there are no merge conflicts because I'm guessing that everything is now in a different directory, but I will resolve that.

devloop0 commented 8 years ago

Also, it would be nice to move all of this opencv dll/so loading to a separate class. Can you do this, or do you want me to?

xnart commented 8 years ago

Yeah you have to put the .so file in that path when you create package.

By the way, i separated loading library and put it in UserPlatform class.

devloop0 commented 8 years ago

Okay. I'll probably modify the path later. I'll accept this merge request for now though.