The pkgstat command doesn't tell the user when it's being used wrong.

the-maldridge / PopCorn

XBPS package statistics system

MIT License

16 stars 3 forks source link

The pkgstat command doesn't tell the user when it's being used wrong. #4

Open ericonr opened 4 years ago

ericonr commented 4 years ago

I don't think it's emergencial or anything, but running

$ popcornctl -server popcorn.voidlinux.org -port 8003 pkgstats

should probably give the same output as

$ popcornctl -server popcorn.voidlinux.org -port 8003 pkgstats -any-wrong-flag

Instead, the output is just

PopCorn doesn't know of any installs for this package

I can also try to look into that, perhaps.

the-maldridge commented 4 years ago

Most of popcorn needs to be rewritten. There are fairly serious architectural issues with it, and I've been putting it off for a while. The google subcommands package is very limited and not a particularly good commands framework in my opinion. Protobuf was also the wrong choice for this package, since both ends are Go it really should have been Gob.

If you wanted to take a stab at slowly refactoring parts I'll review your PRs, but I don't really want to put time into fixing a deeply flawed design right now.