search

the-marenga / sf-api

Manage Shakes & Fidget characters via simple commands. Handles encryption, response parsing and everything else for you
MIT License
15 stars 3 forks source link

Event [Ruffian Reset] rewards aren't correctly parsed in the Gamestate #76

Closed alexb231 closed 3 months ago

alexb231 commented 3 months ago

It's possible that other events are affected too, but this one specifically retrieves wrong Reward informations causing the Gamestate not to update correctly it seems.

This weeks rewards: Rewards: [RewardChest { opened: true, reward: [Some(Reward { typ: Stone, amount: 3120 }), None] }, RewardChest { opened: false, reward: [Some(Reward { typ: ExtraBeer, amount: 1 }), None] }, RewardChest { opened: false, reward: [Some(Reward { typ: Mushroom, amount: 2 }), None] }]

  1. Metal/Crystal is displayed as stone thats fine thats probably just a naming thing
  2. Says Reward is Beer -> Should be gold
  3. Says Mushrooms -> Should be an extra beer (12th Beer)

Anyway, it seems claiming those chests doesnt update the Gamestate correctly, assumption would be its not the correct chest that was actually claimed ?

Repro step:

Check the GameState under: specials.tasks.event.rewards and compare it to the tasks in SF.

BTW: All of the RewardChests were already claimed already at the point of opening this issue.

Thanks

the-marenga commented 3 months ago

Seems like they changed the mapping of the event rewards again. Seems like a good point in time to also finally fix #48. I am going to start working on that