[Bug] Underworld and login

Synzed commented 8 months ago

2 small bugs found:

Even though my Underworld is unlocked it says "UW not unlocked yet"

and a smaller thing: While logging into the tool, you cant switch from username to password field with TAB anymore.

the-marenga commented 8 months ago

Thanks for the report.

The underworld stuff is weird. Could you provide me with the helper.log file, that the helper creates? It might show some warnings about stuff not being parsed correctly.

Yeah, I am probably going to add the login tab stuff soon. It just seemed to be a bit more annoying to implement, than with the old framework, so I just skipped it for now

Synzed commented 8 months ago

censored serverdetails just in case .. :)

the-marenga commented 7 months ago

So there are no relevant errors/warnings in the log. That means the only thing, that could go wrong is that it thinks your underworld is at total_level 0 and removes all the otherwise fine data because of that. I might need to change the way I check if the underworld exists then I suppose. Maybe check for total_level > 0 || buildings.iter().any(|a| a.level > 0) to make extra sure there is something in the underworld.

I will try that in the next release for you, but as I am unable to reproduce this, that might not be enough to fix the issue

Usaksport commented 6 months ago

Unfortunately i have the same bug with the underworld.

garfild1994 commented 3 months ago

So there are no relevant errors/warnings in the log. That means the only thing, that could go wrong is that it thinks your underworld is at total_level 0 and removes all the otherwise fine data because of that. I might need to change the way I check if the underworld exists then I suppose. Maybe check for total_level > 0 || buildings.iter().any(|a| a.level > 0) to make extra sure there is something in the underworld.

I will try that in the next release for you, but as I am unable to reproduce this, that might not be enough to fix the issue

I'm also experiencing this problem. It might be related to the gates, as I haven't unlocked them yet.

2024-07-23 17:05:17 | INFO | sf_scrapbook_helper:105 | Starting up 2024-07-23 17:05:34 | WARN | sf_api::session:299 | Untested S&F Server version: 2007 2024-07-23 17:05:34 | WARN | sf_api::gamestate:897 | Unable to parse combat log entry: ["83650158", "533", "1", "12", "1721749330", "0"] - Error parsing the server response because combat mt had an unexpected value of: 12 2024-07-23 17:05:34 | WARN | sf_api::gamestate:1734 | Weird time stamp: 1 for hydra last defeat 2024-07-23 17:05:34 | WARN | sf_api::gamestate:1419 | Update ignored soulsperhournextlevel -> ResponseVal { value: "330", sub_key: "" } 2024-07-23 17:05:34 | INFO | sf_scrapbook_helper::message:509 | Successfully logged in character-0@14097802973391367298 2024-07-23 17:05:34 | WARN | sf_scrapbook_helper::backup:143 | s12sfgameeu could not read in local backup: Nie można odnaleźć określonego pliku. (os error 2) 2024-07-23 17:05:34 | DEBUG | sf_scrapbook_helper::backup:163 | s12sfgameeu fetch online backup: false 2024-07-23 17:05:34 | DEBUG | sf_scrapbook_helper::backup:27 | Reset crawling progress 2024-07-23 17:05:34 | DEBUG | sf_scrapbook_helper::crawler:218 | Logging in SwsyXM1 on https://s12.sfgame.eu/ 2024-07-23 17:05:34 | DEBUG | sf_scrapbook_helper::crawler:257 | Registering new crawler account SwsyXM1 on https://s12.sfgame.eu/ 2024-07-23 17:05:35 | WARN | sf_api::session:299 | Untested S&F Server version: 2007 2024-07-23 17:05:35 | WARN | sf_api::gamestate:1419 | Update ignored tutorial_game_entry -> ResponseVal { value: "1", sub_key: "" } 2024-07-23 17:05:35 | DEBUG | sf_scrapbook_helper::crawler:273 | Registered SwsyXM1 successfull https://s12.sfgame.eu/

the-marenga / sf-scrapbook-helper

[Bug] Underworld and login #33