search

the-marenga / sf-server

A Shakes & Fidget server in the very early stages of developement
3 stars 1 forks source link

Implement PvP fights #14

Open GutZuFusss opened 2 hours ago

GutZuFusss commented 2 hours ago

At least have a dummy implementation without real fighting sim

GutZuFusss commented 2 hours ago

Is this something you are working on? If not, I would be willing to implement this. This issue is mainly to save us from doing work twice

the-marenga commented 1 hour ago

Is this something you are working on?

I am not currently working on that and it is not on my list in the near future.

If not, I would be willing to implement this

Thanks, but the problem is, that this would probably be one of the, if not the most complex part of the server. I mean this game is mainly just waiting otherwise. The overall battle API (mainly serialization) would have to be generic enough to work for questing, dungeons, guilds, arena, underworld, hydra and if possible even for pets & fortress. All whilst being correct and not too generic, where is gets bogged down in inefficient db calls and multiple layers of abstraction. Even just simple PvP battles are not yet fully implemented in the sf-api and the best way forward would be to do this via a hook in the sf-api, so I don't see how this is a place that should be worked on on the server side yet.

At least have a dummy implementation without real fighting sim

If you just need something for your project, you are free to work on this on your fork, but I just have to warn you, that there is a very high chance I would veto pull requests for this, since I relly want to get this right