HTTP2 bug fix - Githubissues

the-markup / blacklight-collector

GNU General Public License v3.0

201 stars 36 forks source link

HTTP2 bug fix #100

Closed BatMiles closed 2 months ago

BatMiles commented 2 months ago

What does this PR do?

fixes the HTTP2 crash we were seeing on some second page scans
fixes the session recording test
uses URL built-in instead of deprecated library function
removes some unused util functions and collector variables
refactors a number of files into a new subfolder
creates a new hasOwnProperty helper function
various minor improvements: function renaming, removing commented-out logs, whitespace, etc

Why are we doing this? How does it help us?

Crashes are bad

How/where should this be tested?

On it's own and in conjunction with the lambda

What are potential areas for future improvement? Are there any dependencies (especially on 3rd party code)?

There's plenty more refactoring to do, but I figured this PR was getting large enough

What are the relevant tickets, tasks, or documents?

https://calmatters.atlassian.net/jira/software/projects/PRD/boards/15?assignee=712020%3A97109b4a-04d7-464a-b1ce-adb6439221fb&selectedIssue=PRD-7402

Have you done the following, if applicable:

(optional: add explanation between parentheses)

[x] Tested manually
[x] Checked for performance implications? ( )
[x] Checked for security vulnerabilities? ( )
[ ] Added/updated documentation? ( N/A)
[ ] Added/updated tests