Closed BatMiles closed 3 months ago
browser.close()
Pairs with Blacklight Lambda PR 73
The recent updates to puppeteer and the collector types broke Blacklight on staging.
In staging, and locally, by running the collector and lambda and ensuring BL works
Keep an eye on Puppeteer and Chromium releases, hopefully a future one will eliminate this bug
(optional: add explanation between parentheses)
What does this PR do?
browser.close()was hanging indefinitely, leading to the lambda timing out. This 'solution' is in several Github Issue threads about the bug, such as this onePairs with Blacklight Lambda PR 73
Why are we doing this? How does it help us?
The recent updates to puppeteer and the collector types broke Blacklight on staging.
How/where should this be tested?
In staging, and locally, by running the collector and lambda and ensuring BL works
What are potential areas for future improvement? Are there any dependencies (especially on 3rd party code)?
Keep an eye on Puppeteer and Chromium releases, hopefully a future one will eliminate this bug
Have you done the following, if applicable:
(optional: add explanation between parentheses)