Closed bobjrsenior closed 2 years ago
Those dependencies are only required when building packages for the LVFS, I should probably get all that out of the 'make everything' command as only people doing local updates with fwupd for testing purposes, or me getting a new release are going to make use of that.
pylint3
could be changed to pylint
as most distros should have an alias for it, but if you don't mind, I think it would be better to keep the dependencies for the SDK and fwupd specific stuff separate
I didn't expect the issue to close when I did that force-push. I'm pretty sure I've done that once without issue/PR changes.
Anyway, I was wondering what the cab file was for. Keeping the dependencies separate works for me.
I overwrote my commit (to keep history clean since it's a minor change) with one that changes pylint3
to pylint
and moves the fwupd specific dependencies (php
and gcab
) into a separate step.
Merged, thank you!
When running "make everything", the last make step ("cab_file") requires both php and gcab. Without them, the image files still get made but the build is marked as a failure.
I added the php and gcab dependencies in the existing list but it seems that list came from the Yocto docs so I'm not sure if there should be a separate non-Yocto dependency list to make future changes easier.
I also had to change
pylint3
to justpylint
but I don't know if that's just my system so I didn't change it in the list.