search

the-orange-alliance / toa-angular-old

🤖 A webapp for accessing data about the FIRST Tech Challenge
https://theorangealliance.org
MIT License
45 stars 31 forks source link

Correct events on TOA with incorrect team lists #240

Closed cheer4ftc closed 5 years ago

cheer4ftc commented 5 years ago

In a previous issue, I reported that team lists were incorrect for some events on TOA. That issue was closed when the DataSync was changed to report team lists based on the match lists. So that should fix issues with future events (hopefully: fingers crossed).

But there are still events on TOA from before this fix was made that have buggy team lists. For example: https://theorangealliance.org/events/1819-VA-QTVA6B https://theorangealliance.org/events/1819-VA-QTVA2b And the problem is that these buggy team lists propagate to the TOA team pages, showing teams playing at the same event twice, or playing in events where they didn't actually play. For example: https://theorangealliance.org/teams/9901 https://theorangealliance.org/teams/10030

Can the database of existing events be cleaned so that the team lists and rankings match the teams that appear in the match list for all events?

I note that this was a perpetual problem in the 1718 season (https://theorangealliance.org/events/1718-VA-CMP2 STILL has the wrong team list, making the teampages for every team at that event incorrect). This makes the TOA pages look buggy and error-prone. It would be nice to see improvement in this for the 1819 season.

Techno11 commented 5 years ago

All of these errors have been fixed. (including the 1718 event) Please let me know if you see any more problems.

cheer4ftc commented 5 years ago

https://theorangealliance.org/events/1819-VA-QTVA2B still shows 22 ranked teams but 27 teams in the team list ??? Otherwise, the other events look better! Thanks!

cheer4ftc commented 5 years ago

And the duplicated teams still show the event twice on their teampage, e.g., https://theorangealliance.org/teams/9064

Techno11 commented 5 years ago

I did miss that, The issue has been corrected. I cross-references the teams from the rankings to the Teams list.