search

the-orange-alliance / toa-angular-old

🤖 A webapp for accessing data about the FIRST Tech Challenge
https://theorangealliance.org
MIT License
45 stars 31 forks source link

Penalties given to the wrong team on match summary pages? #253

Closed cheer4ftc closed 4 years ago

cheer4ftc commented 5 years ago

https://theorangealliance.org/matches/1819-NM-QTNM3-E007-1 The score was 180 - 130 with a major penalty called on red that gave blue 40 points. The match summary page shows the penalty on blue giving red 40 points, even though the final score of 180-130 is correct. If you add up the (incorrect) penalty points shown on that match page, the score would be 220-90.

Techno11 commented 5 years ago

@afera15

afera15 commented 5 years ago

So this goes back to we need to show who got the penalty. I can definitely so how this is confusing so I'll play with a few examples of how we want to report this and bring a few options.

Techno11 commented 4 years ago

@cheer4ftc Has this been fixed? Is there anything you would like to see done? @afera15 Have you found anything out?

cheer4ftc commented 4 years ago

It looks pretty good here: https://theorangealliance.org/matches/1920-GA-NGMN1-Q012-1 You can see that blue was penalized twice (major) so red got 20 penalty points. I might only suggest that, under blue, just show "2" and not "2 (+40)" as it isn't +40 for blue.