search

the-orange-alliance / toa-angular-old

🤖 A webapp for accessing data about the FIRST Tech Challenge
https://theorangealliance.org
MIT License
45 stars 31 forks source link

Can't open in new tab #31

Closed Chris857 closed 7 years ago

Chris857 commented 7 years ago

There are many places where I can't middle click to open a link in a new tab (such as team list, event list). On an individual team page (say http://beta.theorangealliance.org/teams/4133), I can open the event page and team pages in a separate tab, but not the matches.

afera15 commented 7 years ago

We will be investigating this issue.

Chris857 commented 7 years ago

If it's helpful: I'm on Firefox 50.1.0 on Fedora 23.

afera15 commented 7 years ago

I tested this and it seems to be in issue in all browser on windows as well Chrome Firefox Edge Safari

afera15 commented 7 years ago

I believe this has something to do with <a (click)="action">

kyle-flynn commented 7 years ago

This isn't really an 'issue'. This is something that Angular 4 almost discourages. (The site is a Single Page Application). I will probably go over all anchor tags and change them to <a href="/link" once other issues are closed.

afera15 commented 7 years ago

Fixed in Commit acce26d