the-orange-alliance / toa-angular-old

🤖 A webapp for accessing data about the FIRST Tech Challenge
https://theorangealliance.org
MIT License
45 stars 29 forks source link

Some of the scores do not match details in the API and also on the website #388

Closed johnnguyenboston closed 3 years ago

johnnguyenboston commented 4 years ago

Describe the bug The auto & end-game scores do not match the details of power shots and wobble goals scored.

Steps to reproduce the issue Go to https://theorangealliance.org/matches/2021-RUS-RFSPM-Q001-1

In the GUI, auto score is 37 but the details only show 2 parks and 1 ring in high goal, which totals 22. There are 15 points missing which seems to be a wobble score. The API also has a mismatch since it returns 15 for auto_wobble_points for red, but the API also returns False for both auto_wobble_delivered_1 and auto_wobble_delivered_2.

For the same match, blue scored a powershot during endgame which is shown correctly in the GUI, but none of the end_power_shot_left/center/right values are True.

Expected behavior The detailed results and scores are expected to match

Screenshots API result for red for 2021-RUS-RFSPM-Q001-1 is below. Note the discrepancy between auto_wobble_points and auto_wobble_delivered_1/2.

{u'auto_wobble_points': 15, u'auto_tower_high': 1, u'auto_power_shot_center': False, u'tele_tower_high': 2, u'end_wobble_points': 0, u'tele_tower_mid': 0, u'auto_power_shot_right': False, u'end_power_shot_center': False, u'auto_tower_low': 0, u'end_wobble_1': 0, u'auto_tower_mid': 0, u'end_nav_points': -1, u'auto_tower_points': 12, u'end_power_shot_points': 0, u'end_wobble_2': 0, u'end_wobble_rings_2': 0, u'end_wobble_rings_1': 0, u'end_power_shot_left': False, u'auto_nav_pts': -1, u'auto_power_shot_points': 0, u'end_power_shot_right': False, u'auto_wobble_delivered_1': False, u'auto_wobble_delivered_2': False, u'auto_navigated_2': True, u'end_wobble_ring_points': 0, u'auto_navigated_1': True, u'tele_tower_low': 1, u'auto_power_shot_left': False}

API result for blue for 2021-RUS-RFSPM-Q001-1 is below. Note the discrepancy between end_power_shot_points and end_power_shot_left/center/right.

{u'auto_wobble_points': 0, u'auto_tower_high': 0, u'auto_power_shot_center': False, u'tele_tower_high': 0, u'end_wobble_points': 0, u'tele_tower_mid': 0, u'auto_power_shot_right': False, u'end_power_shot_center': False, u'auto_tower_low': 3, u'end_wobble_1': 0, u'auto_tower_mid': 0, u'end_nav_points': -1, u'auto_tower_points': 9, u'end_power_shot_points': 15, u'end_wobble_2': 0, u'end_wobble_rings_2': 0, u'end_wobble_rings_1': 0, u'end_power_shot_left': False, u'auto_nav_pts': -1, u'auto_power_shot_points': 0, u'end_power_shot_right': False, u'auto_wobble_delivered_1': False, u'auto_wobble_delivered_2': False, u'auto_navigated_2': False, u'end_wobble_ring_points': 0, u'auto_navigated_1': True, u'tele_tower_low': 2, u'auto_power_shot_left': False}

Additional context Add any other context about the problem here.

Your Environment

devyntk commented 4 years ago

This is actually a bug with the upstream data from FIRST, where the live event didn’t correctly record these scores. We’ve already reported it to them and supposedly a fix is coming, and we’ll fix these events when it does.

johnnguyenboston commented 4 years ago

What's strange is that the data reported by FTC's site does have the correct powershot results for endgame: Look at blue for https://ftc-events.firstinspires.org/2020/RUSTM1/qualifications/1 where it shows endgame center power shot was scored.

ofekashery commented 3 years ago

Fixed. image