the-programmers-hangout / website

🌳 TPH website
https://theprogrammershangout.com
MIT License
102 stars 67 forks source link

Home: fix svg waves across resolutions #110

Closed veksen closed 4 years ago

veksen commented 5 years ago

Find a better way to implement the waves across resolutions.

Possibly catalogue the homepage across common resolutions on Figma to get a "best case scenario".

bad: 2560x1440 @ 2560x955 body

ItsAzaria commented 4 years ago

I've noticed that there seems to be an extra path on the bottom wave svg that isn't needed and causes the strange curve

screenshot before image

screenshot after deleting url(#bot_gradient5)path from the bottom wave svg image

May also be related but on both images there's a small gap at the bottom that is missing colours

this is all at 2560x1440 @ 2560x981 body

veksen commented 4 years ago

@Moe-Szyslak that's actually a very good fix!

You're free to do a PR, otherwise I can do it

puremana commented 4 years ago

I think you can close this issue now