the-programmers-hangout / website

🌳 TPH website
https://theprogrammershangout.com
MIT License
102 stars 67 forks source link

feat: Implement Mdx #286

Closed dfireBird closed 4 years ago

dfireBird commented 4 years ago

I ported mostly every thing to support Mdx plugin.

There is unresolved issues: When I try to add plugin (gatsby-remark-auto-headers-improved) to Mdx plugin it throws a load of errors. It's most probably an upstream bug I need more information to open an issues on the repo.

Edit: Installing the plugin with npm and using it Mdx plugins works.

veksen commented 4 years ago

Thank you so much! The failing build is my fault, the master branch build is currently failing, so I need to resolve that first!

dfireBird commented 4 years ago

I generated graphQL types just by providing a sample .graphql (since there are no .graphql files) is that the correct way?

dfireBird commented 4 years ago

There is discussion going on in this issue about module not found when using local plugins.

veksen commented 4 years ago

I did not give up on this :D sorry! I'm waiting and hoping for the issue with the local plugin, sadly gatsby-remark-auto-headers-improved is super key... I might need to create a npm package if it's not resolved

dfireBird commented 4 years ago

Thanks for explaining it! I thought you put this out for some other reason lol.

Edit: Why did you chose not to convert it a npm package?

veksen commented 4 years ago

I've externalized the library to npm https://github.com/the-programmers-hangout/website/pull/311

It's still possible that it doesn't play ball well due to the way the library interacts with Remark, I have to look at that, if so

dfireBird commented 4 years ago

I need to add the gatsby-remark-auto-headers-improved in both plugins option and gatsbyRemarkPlugins option because of this issue

veksen commented 4 years ago

I'm going to test it today and see if we can finally merge it. Does everything seem stable from your side?

Thank you again for handling this!

dfireBird commented 4 years ago

Everything seem stable on my side.