Adjust Header heights to fit Box content

the-programmers-hangout / website

🌳 TPH website

https://theprogrammershangout.com

MIT License

102 stars 67 forks source link

Adjust Header heights to fit Box content #343

Open travisk-codes opened 4 years ago

travisk-codes commented 4 years ago

Changes:

Constrains height of the Header component to fit the text content of the Box component (see screenshots)
Fixes #339

Additional Notes:

Probably wanna test on your machine before commit, a lot of positioning changes.
Makes subjective design decisions, please offer feedback (e.g. should the Header have a min-height?

Screenshots: Before: tph-header-auto-height-1-before After: tph-header-auto-height-1-after Before: tph-header-auto-height-2-before After: tph-header-auto-height-2-after Before: tph-header-auto-height-3-before After: tph-header-auto-height-3-after Before: tph-header-auto-height-4-before After: tph-header-auto-height-4-after

veksen commented 4 years ago

So, a lot going on here, there's a few things I'm not happy with, and I'm realizing my intent with the design and layout is not clear. I'm going to sketch out the various layouts and we can discuss the changes needed.

veksen commented 3 years ago

Sorry, left this for a while, and did a conflicting PR (https://github.com/the-programmers-hangout/website/pull/376). Let me know if you'd like to go over this :D