the-programmers-hangout / website

🌳 TPH website
https://theprogrammershangout.com
MIT License
103 stars 69 forks source link

feat: yarn migration #425

Closed SagnikPradhan closed 2 years ago

Xetera commented 2 years ago

Do we really need all of these files? Yarn 2 is such a hassle honestly I don't know of a single person who uses it

SagnikPradhan commented 2 years ago

Do we really need all of these files?

Assuming you are referencing to the sdk files, yes. It is for adding support to the editors.

Yarn 2 is such a hassle honestly I don't know of a single person who uses it

Do agree with it being hassle, but yarn is on version 3 now, classic isn't being updated.

Xetera commented 2 years ago

FYI you can use netlify dev to check to see if this builds locally instead of pushing potential fixes

SagnikPradhan commented 2 years ago

FYI you can use netlify dev to check to see if this builds locally instead of pushing potential fixes

OML sorry and thanks

SagnikPradhan commented 2 years ago

I think I am done with this, all there is left to do is probably the site configuration itself on dashboard.

configure builds edit build settings ui

Xetera commented 2 years ago

Sorry I don't really know what the issue with discord.js not being found is. Dev dependencies aren't being installed maybe?

SagnikPradhan commented 2 years ago

The scripts are being called using npm, they should be called with yarn.

Xetera commented 2 years ago

Can you add a netlify.toml to run that build step instead

SagnikPradhan commented 2 years ago

Sure, give me a few minutes.

SagnikPradhan commented 2 years ago

Geee, thanks.

veksen commented 2 years ago

I'm okay with the content of this PR, but this could/should have been split into smaller PRs, there's no good reason to bump the deps alongside moving to Yarn. If the PR was problematic, the whole thing would of been rolled back, undesirable :)

SagnikPradhan commented 2 years ago

If the PR was problematic, the whole thing would of been rolled back, undesirable :)

Sheesh, did not think about that.