search

the-radiativity-company / inmates

a tool for collating inmate rosters
2 stars 1 forks source link

Initial Item class setup #15

Open pjsier opened 4 years ago

pjsier commented 4 years ago

Progress on #14

This definitely doesn't cover all of the fields we would want, but wanted to have a starting point. Feedback would be great!

I'm using attrs here instead of a dataclass because it seems a bit more flexible, especially in validating types.

withtwoemms commented 4 years ago

would like to get this in @pjsier. what are your thoughts on moving inmates_scracper.items.values_are_in_list?

pjsier commented 4 years ago

I don't have an issue with it, maybe something like validators.py? I only left it in because I'm not sure we'd have any others, but I don't have strong feelings about it