search

the-reefshark / pe

0 stars 0 forks source link

Cannot recall previously entered command if it is incorrect #6

Open the-reefshark opened 3 years ago

the-reefshark commented 3 years ago

Upon executing an incorrect command, it is not possible to recall that command eg. in a case where you made a typo and want to fix it, it will instead recall the last command that was successful. This is also not mentioned in the User Guide section that describes this feature.

After executing this incorrect command: Screenshot 2020-11-13 at 4.58.14 PM.png

When I try to recall:

Screenshot 2020-11-13 at 4.58.51 PM.png I instead get the last successful command

nus-pe-bot commented 3 years ago

Team's Response

This is the intended behaviour of the feature.

The command recall feature only stores successful commands.

In the case where a typo was made and an error as shown occured, the user can edit the message directly without need for using the command recall feature.

In addition, the command with the typo is the current command and hence after pressing up we retrieve the previous command.

If the user has accidentally pressed the up arrow, he/she can press the down arrow key to retrieve this current command and edit it.

Therefore, there is no inconvience caused to the user.

Severity is lowered since no inconvience is caused to the user.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I disagree with this as I feel that in most other applications especially the unix terminal (where I believe this feature was inspired from) the behaviour is such that the user is able to recall mistyped commands and an argument can be made that users are more likely to want to recall a command that they have mistyped instead of re-typing a successfully executed command. And as for this being the desired feature of the application, this behaviour is not stated in the user guide which states that the arrow keys can be used to "navigate around previously entered commands" without stating that this is only applicable for successfully executed commands. I feel this is a problem as most users of this CLI application, that likely are terminal users as well will feel confused by this implementation.

image.png

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]