Closed rpweb closed 5 years ago
Amazing @rpweb You should open source it once you have finished the pagination feature 💯 🥇
I couldn't look at everything, but here are two things I noticed:
I think you are not using Prettier for automated code formatting. Perhaps it would be great to align the code formatting (2 spaces, only one line of space in between, ...). I have configured my Prettier to work on save if a .prettierrc file is available in the project.
The last 3 days I overhauled the project with a couple of fixes and upgrades. You can find them over here. 3 Important changes: Babel 7, fixes for Heroku, graphql-iso-date with custom scalars (because I have seen you configured the default date over here and I went the other way to keep the database information with its defaults and only translate it with the custom scalar).
After releasing the open source project, we could extend the tutorial with MongoDB if it doesn't differ too much from the original project. I would hope that only the resolvers, the seeding in the src/index.js and the models/ folder changes. Then it would be fairly straight forward to offer readers a substitution for chapters:
I can do it, you can do it as guest blog post, or you can do the substituted chapters on your own website too. As you wish.
Another idea: If the React client didn't change for you, it may be great to extract the client from both repositories and keep only the server part. Then I would introduce a separate repository for the React client and both server repositories could point to it.
One more idea: We could name the repositories fullstack-apollo-react-express-postgresql-boilerplate-project and fullstack-apollo-react-express-mongodb-boilerplate-project. If you want, you could join the organization as well and put the repository in here. But that's up to you :)
Nevertheless, well done so far! 🎉
yes sure, spread it with everyone. here the latest final version with your latest changes as well: https://github.com/webstudios/fullstack-apollo-react-express-boilerplate-project as you can see on client side i did only some bug fixes in general. on server side the index changed slightly and of course mainly the loaders, models, resolvers and a little bit the schema due to the date. here a fix to display the correct date is needed. i added lint-staged and husky to package.json to avoid automated code formatting issues in the future. @priestor helped me alot and should be mentioned as well! it would be great if you can take care of the missing chapters. you are obviously the better author. you can decide which idea is best for everyone. i added you as a collaborator to the fork. thanks again for your tutorial!
i created a mongo version. https://github.com/rpweb/fullstack-apollo-react-express-boilerplate-project not finished, but everything works, except pagination. would be great if you can give me some feedback. thanks