search

the-road-to-react-with-firebase / react-firebase-authentication

🔥 Boilerplate Project for Authentication with Firebase in React.
https://www.robinwieruch.de
1.02k stars 298 forks source link

Removing onAuthStateChanged listeners #7

Closed shaibt closed 5 years ago

shaibt commented 6 years ago

Hi, Great tutorial and example code! Definitely most comprehensive from all the react/firebase stuff I've seen. Just a small comment, wouldn't be cleaner to remove the onAuthStateChanged listeners in the two HOCs in a componentWillUnmount method?

rwieruch commented 6 years ago

Good point. I should add those to the tutorial!

rwieruch commented 5 years ago

Fixed :)