Using a class rather than an inline function for the component property in Route

[tezzutezzu]

Hi @rwieruch and thanks for your hard work on this.

In your example, shouldn't the Route components' value be a class rather than an inline function?

According to react-router docs, in that way a new component is created every time rather than being updated.

Here's a proposed change:

<Route exact path={routes.LANDING} component={LandingPage} />

<Route exact path={routes.SIGN_UP} component={SignUpPage} />

<Route exact path={routes.SIGN_IN} component={SignInPage} />

<Route exact path={routes.PASSWORD_FORGET} component={PasswordForgetPage} />

<Route exact path={routes.HOME} component={HomePage} />

<Route exact path={routes.ACCOUNT} component={AccountPage} />

[rwieruch]

Good point. Do you have the time to fix it first over here: https://github.com/rwieruch/the-road-to-react-with-firebase in a PR? Afterward, all applications built in the tutorial should be adjusted as well (which I can do):

• https://github.com/taming-the-state-in-react/react-firebase-authentication
• https://github.com/taming-the-state-in-react/react-redux-firebase-authentication
• https://github.com/taming-the-state-in-react/react-mobx-firebase-authentication

[rwieruch]

Fixed in tutorial, will fix later in applications.