search

the-scouts / compass-interface-core

Core bridge/crawler component for Compass-Interface
5 stars 1 forks source link

♻️ Clarify that Logon properties are immutable #103

Closed AA-Turner closed 3 years ago

AA-Turner commented 3 years ago

This has been intended for a while, but unclear. Allows simplification of logic elsewhere.

codecov[bot] commented 3 years ago

Codecov Report

Merging #103 (7e29b99) into master (e785c9d) will decrease coverage by 0.09%. The diff coverage is 51.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   67.20%   67.10%   -0.10%     
==========================================
  Files          31       31              
  Lines        1674     1675       +1     
==========================================
- Hits         1125     1124       -1     
- Misses        549      551       +2
Impacted Files Coverage Δ
compass/core/__init__.py 68.75% <0.00%> (ø)
compass/core/hierarchy.py 30.30% <0.00%> (-0.40%) :arrow_down:
compass/core/people.py 43.58% <ø> (+1.08%) :arrow_up:
compass/core/reports.py 51.35% <0.00%> (ø)
compass/core/_scrapers/reports.py 28.76% <50.00%> (-1.37%) :arrow_down:
compass/core/logon.py 74.28% <54.83%> (-0.72%) :arrow_down:
tests/compass/core/test_compass_core_logon.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e785c9d...7e29b99. Read the comment docs.