search

the-scouts / compass-interface-core

Core bridge/crawler component for Compass-Interface
5 stars 1 forks source link

♻️ Create Logon.from_logon to fix props bug #48

Closed AA-Turner closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #48 (7070227) into master (a358107) will increase coverage by 0.29%. The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   55.62%   55.92%   +0.29%     
==========================================
  Files          22       22              
  Lines        1458     1452       -6     
==========================================
+ Hits          811      812       +1     
+ Misses        647      640       -7
Impacted Files Coverage Δ
compass/core/__init__.py 100.00% <ø> (ø)
compass/core/logon.py 29.45% <14.28%> (+2.29%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a358107...110f2f4. Read the comment docs.

AA-Turner commented 3 years ago

Logon.__init__ assumed self.compass_props existed during the method, whereas when constructing from session it was set afterwards. Now split the logic fully, and provide a unified Logon constuctor.