the-scouts / compass-interface-core

Core bridge/crawler component for Compass-Interface
5 stars 1 forks source link

πŸ”– RLS: v0.11.0 #70

Closed AA-Turner closed 3 years ago

AA-Turner commented 3 years ago

2 API changes:

Internal changes include a refactor of _scrapers/member.py - this file is still just short of 1,000 lines long, but hopefully now control flow is slightly easier to follow, as I've added a number of helper functions. Also continued to move away from xpath for performance improvements of ~100x in some cases, though this is at the parsing stage - network I/O to compass still takes up the vast majority of time. (In a recent test, 300ms network I/O, 75ms parsing -> 80% of time spent on I/O).

codecov[bot] commented 3 years ago

Codecov Report

Merging #70 (3ab7db2) into master (5caa213) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #70   +/-   ##
=======================================
  Coverage   65.12%   65.12%           
=======================================
  Files          28       28           
  Lines        1600     1600           
=======================================
  Hits         1042     1042           
  Misses        558      558           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 5caa213...3ab7db2. Read the comment docs.