search

the-sett / elm-syntax-dsl

A DSL for creating Elm syntax trees and pretty printing Elm source code.
BSD 3-Clause "New" or "Revised" License
20 stars 4 forks source link

Add fully qualified type annotation. #21

Open akoppela opened 4 years ago

akoppela commented 4 years ago

Thanks for nice package. Type annotation functions are missing fully qualified type. There is fqTyped but that's for a type with parameters. So fqTypeVar is missing.

rupertlssmith commented 4 years ago

Ok, that could be a useful one to add.

It should be equivalent to fqTyped but with zero type parameters?

fqTypeVar : ModuleName -> String -> TypeAnnotation
fqTypeVar mod name = 
    fqTyped mod name []
akoppela commented 4 years ago

It should be equivalent to fqTyped but with zero type parameters?

Correct

lue-bird commented 3 years ago

Hmmm. It would be strange to have

typed
fqTyped

but then

typeVar
fqTypeVar

not following this naming scheme and having completely different meanings.