Currently, physical_min and physical_max are rounded via string formatting when writing them to their respective header fields, to fit the 8 character limit. This can lead to a situation where e.g. physical_max is rounded down, making it smaller than some actual (physical) signal values. Always rounding physical_mindown and physical_maxup ensures that all signal values lie within the physical range. This should make clipping the digital values to the digital range in EdfSignal._set_data obsolete and thereby close #1.
Currently,
physical_min
andphysical_max
are rounded via string formatting when writing them to their respective header fields, to fit the 8 character limit. This can lead to a situation where e.g.physical_max
is rounded down, making it smaller than some actual (physical) signal values. Always roundingphysical_min
down andphysical_max
up ensures that all signal values lie within the physical range. This should make clipping the digital values to the digital range inEdfSignal._set_data
obsolete and thereby close #1.