the-siesta-group / edfio

Read and write EDF/EDF+ files.
Apache License 2.0
28 stars 4 forks source link

Expand tilde in `read_edf()` #23

Closed cbrnr closed 9 months ago

cbrnr commented 10 months ago

Fixes #22.

hofaflo commented 10 months ago

I just tried to write a test using a symlinked file or directory (to make sure .resolve() works), but apparently .resolve() is not necessary, as it works either way (at least on linux) :shrug:

Another thought: we should probably use .expanduser() in Edf.write() as well

cbrnr commented 10 months ago

I just tried to write a test using a symlinked file or directory (to make sure .resolve() works), but apparently .resolve() is not necessary, as it works either way (at least on linux) 🤷

No idea what this actually does, it probably doesn't hurt to leave it in. But it's up to you, let me know if you want me to remove it.

I'll add it to Edf.write(), sure.

cbrnr commented 10 months ago

(I didn't mean to put my last comment in a review. I meant to write a normal comment, but the UI from within VS Code is... not ideal.)

hofaflo commented 9 months ago

Thanks @cbrnr!