the-siesta-group / edfio

Read and write EDF/EDF+ files.
Apache License 2.0
28 stars 4 forks source link

Refactor header fields #42

Closed hofaflo closed 6 months ago

hofaflo commented 6 months ago

The intention behind the current implementation of header fields in the Edf and EdfSignal classes, based on RawHeaderFields, was to avoid bugs caused by having to repeat the field length everywhere a header field is set. However, it comes with a few issues:

I think these issues outweigh the initially desired benefit and would therefore like to replace the custom descriptors with ordinary properties.

hofaflo commented 6 months ago

Resolved merge conflict, @marcoross please re-approve :)