search

the-simian / es6-plato

JavaScript source code visualization, static analysis, and complexity tool
MIT License
205 stars 40 forks source link

Reviving es6-plato to support ES2020 features #117

Closed pete-the-pete closed 2 years ago

pete-the-pete commented 3 years ago

Addressing https://github.com/the-simian/es6-plato/issues/108

This seems like a lot, but much of it is formatting and small changes. I squashed a few of my commits but left some of the history; at one point I used imports and then converted back to commonJS.

The babel stuff is a little weird, and probably very specific to what I was doing at the time which was to use this on project with an estlintrc file that I couldn't/didn't want to modify at the time.

I'll continue to tweak this as necessary, but its at least capable of running on itself and the project i've been using it for.

the-simian commented 3 years ago

Quick question, why did you bother to change tabs to spaces in this PR? that seems out of scope for what this is about

pete-the-pete commented 3 years ago

Ya...I don't know, it was something I did thinking this would only ever be an isolated fork.

On Tue, Jun 8, 2021, 8:39 AM Jesse Harlin @.***> wrote:

Quick question, why did you bother to change tabs to spaces in this PR? that seems out of scope for what this is about

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/the-simian/es6-plato/pull/117#issuecomment-856880018, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACUPAL4A7RPPLKFLCAIQNLTRY2UTANCNFSM46KC7IVQ .

the-simian commented 3 years ago

thanks for the reply, that's fair. I'll check it out pete, thank you so much for the PR