the-spice-mice / web-app

https://unruffled-payne-a48dae.netlify.com/
0 stars 0 forks source link

Goals & a rubric for code #18

Open ksheedy opened 5 years ago

ksheedy commented 5 years ago
0 points 1 points 2 points 3 points
Personality & design Bland, boring, just another graphic designer Fairly generic, visual design could be pushed more Quality layouts and unique, personable content & design Unique and applicable to target audience, with engaging, personable content & design
Text content Fake content only Some real content, some fake All real content but with lots of errors Real content, well written, no grammar or spelling errors
Accessibility No considerations Added some alt attributes, nothing else Just the basics: alt attributes, roles Accessibility is well considered and tested
Pages & images Barely started Missing lots of pages & images Has most of the pages, some placeholder images All pages exist and are well done with complete imagery
Image quality Only placeholder images Some images Lots of images but low quality High quality and adorable dog images — and lots of them
Responsiveness Not responsive Works on some screens Responsive but with lots of awkwardness Looks great on all screen sizes
Performance Mega slow… Slow… Could load faster Blazing fast awesomeness
JavaScript
(If it exists)
Completely broken Semi-functional Works okay but the non-JavaScript experience is better Very much improves the experience
Code quality Barely started Indentation is barely existent, lots of validation errors, very poor semantics Decent indentation, just a couple validation errors, decent semantics Well indented, fully valid, good semantics
User Testing Not done Barely started Completed but issues not remedied Completed and all issues remedied
Dog Content Angry barking at the neighbour Whimper and scratching at the door Happy woof and tail wag You just arrived home from an extended vacation and your dog is super duper happy to see you
ksheedy commented 5 years ago
0 points 1 points 2 points 3 points
Personality & design Bland, boring, just another graphic designer Fairly generic, visual design could be pushed more Quality layouts and unique, personable content & design Unique and applicable to target audience, with engaging, personable content & design
Text content Fake content only Some real content, some fake All real content but with lots of errors Real content, well written, no grammar or spelling errors
Accessibility No considerations Added some alt attributes, nothing else Just the basics: alt attributes, roles Accessibility is well considered and tested
Pages & images Barely started Missing lots of pages & images Has most of the pages, some placeholder images All pages exist and are well done with complete imagery
Image quality Only placeholder images Some images Lots of images but low quality High quality and adorable dog images — and lots of them
Responsiveness Not responsive Works on some screens Responsive but with lots of awkwardness Looks great on all screen sizes
Performance Mega slow… Slow… Could load faster Blazing fast awesomeness
JavaScript
(If it exists)
Completely broken Semi-functional Works okay but the non-JavaScript experience is better Very much improves the experience
Code quality Barely started Indentation is barely existent, lots of validation errors, very poor semantics Decent indentation, just a couple validation errors, decent semantics Well indented, fully valid, good semantics
User Testing Not done Barely started Completed but issues not remedied Completed and all issues remedied
Dog Content Angry barking at the neighbour Whimper and scratching at the door Happy woof and tail wag You just arrived home from an extended vacation and your dog is super duper happy to see you

Personality and Design -we took the time to create unique icons and details that give the site personality -not only fun and interesting, but it also directly markets to our target audience -interactive pieces create engaging user experiences

Text Content -text was written for each section and each individual sitter profile -content was reviewed thoroughly for spelling and grammar

Accessibility -alt tags have been done for all images -skip links and roles have been included -followed proper heading and layout structures -colour contrast allows for easy viewing and daltonism tests have been conducted

Pages and Images -All pages exist and are well done with complete imagery -each sitter has their own complete profile

Responsiveness -each pattern was reviewed in detail to ensure that it works as well as possible for each screen size -grids were utilized throughout the website to allow for effective responsiveness

Performance

Screenshot 2019-03-11 12 22 35 Screenshot 2019-03-11 12 31 57

Javascript -used to create a seamless login functionality by changing hrefs to simulate proper linking -used to create functional collapsable menus and navigations -used to create a photo array -used for proper focus states for accessibility -used to create tab bar pattern

Code quality -code is properly indented throughout -code has proper semantics -Jekyll is utilized fully to enhance the reusability of code at an advanced level

User testing -user testing has been completed -some, but not all issues have been remedied

Dog content A+ dog content DSC_0921 54278466_517631462094057_6633828411762540544_n