the-spice-mice / web-app

https://unruffled-payne-a48dae.netlify.com/
0 stars 0 forks source link

Pulling in data error in Patternbot vs on index page #72

Closed arobillard closed 5 years ago

arobillard commented 5 years ago

Hi @thomasjbradley

I was working more on using data loops on our app and am having another issue. On Monday we were able to get the data to work properly in the index.html, however now it is not working properly in the pattern library.

I think the problem is that in the Patternbot default example the rating data is being written as a string with quotations so it isn't reading it correctly. However, I am not sure how to set up the defaults to not include the quotations.

Any help is appreciated! Thanks!

screen shot 2019-02-08 at 10 04 27 am screen shot 2019-02-08 at 10 03 35 am screen shot 2019-02-08 at 10 05 17 am

thomasjbradley commented 5 years ago

Yep—that’s exactly the problem. It’s a bug in Patternbot. Patternbot needs to detect whether quotes are needed or not and create its example appropriately.

I’ll get back to you when I fix the problem.

arobillard commented 5 years ago

Ok thanks! It isn't hindering me from being able to wok so there is no major rush.

thomasjbradley commented 5 years ago

This should be fixed now!

gem install jekyll_patternbot
bundle update

I’ve also added categories to the CSS @utility & @var comments: use + then some word (or words separated by -). Some examples:

:root {
  /* @var +border The default border radius */
  --border-radius: 8px;
}

/* @utility +font-related Set the text to the primary typeface */
.font-primary {}