the-tcpdump-group / libpcap

the LIBpcap interface to various kernel packet capture mechanism
https://www.tcpdump.org/
Other
2.66k stars 844 forks source link

Include libpcap on insensitive case filesystem will include incorrect VERSION file #1100

Closed clementperon closed 2 years ago

clementperon commented 2 years ago

Hi,

When compiling libpcap in another project I got an issue when building on mac with insentive case filesystem.

include will include the VERSION file from libpcap instead of the version for the stdc++ library :face_exhaling:

[ 72%] Building CXX object Pcap++/CMakeFiles/PcapPP.dir/src/RawSocketDevice.cpp.o
In file included from /Users/runner/work/PcapPlusPlus/PcapPlusPlus/Pcap++/src/PcapFilter.cpp:3:
In file included from /Users/runner/work/PcapPlusPlus/PcapPlusPlus/Pcap++/header/PcapFilter.h:4:
In file included from /Users/runner/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/string:504:
In file included from /Users/runner/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/string_view:175:
In file included from /Users/runner/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/__string:56:
In file included from /Users/runner/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/algorithm:639:
In file included from /Users/runner/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/initializer_list:46:
In file included from /Users/runner/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/sysroot/usr/include/c++/v1/cstddef:37:
/Users/runner/work/PcapPlusPlus/PcapPlusPlus/Dist/_deps/pcap-src/version:1:1: error: expected unqualified-id
1.11.0-PRE-GIT

Does renaming VERSION to VERSION.txt is ok ? (https://trac.macports.org/ticket/59575)

infrastation commented 2 years ago

See also #1043.

clementperon commented 2 years ago

Thanks i'm including the libpcap as a CMake subfolder, so I can't install it.

I will close this issue as it's a duplicate of #1043

guyharris commented 2 years ago

Duplicate of #1043