the-tcpdump-group / tcpdump

the TCPdump network dissector
https://www.tcpdump.org/
Other
2.7k stars 842 forks source link

Get rid of support for libpcap prior to 1.0. #1183

Closed guyharris closed 4 months ago

guyharris commented 4 months ago

This lets us remove a bunch of configure-time and compile-time tests.

WinPcap 4.1.3 is based on libpcap 1.0, but doesn't export all of the new APIs, so it won't work with code that uses any of the other APIs, which tcpdump does, so don't test with WinPcap.

fxlb commented 4 months ago
Also in the man page, we could remove:
              The -D flag will not be supported if tcpdump was built  with  an
              older  version of libpcap that lacks the pcap_findalldevs(3PCAP)
              function.

And replace:
              If  the  -D flag is supported, an interface number as printed by
              that flag can be used as the interface argument, if no interface
              on the system has that number as a name.

by:
              An interface number as printed by the -D flag can be used as the
              interface argument, if no interface on the system has that number
              as a name.
guyharris commented 4 months ago

Also in the man page man page ...

Done.

infrastation commented 4 months ago

These changes need an entry in the change log and a note in the "Dependency on libpcap" section of README.md, also possibly in INSTALL.md.

fxlb commented 4 months ago

man page, remove ?

              The  -U  flag will not be supported if tcpdump was built with an
              older version of libpcap that lacks  the  pcap_dump_flush(3PCAP)
              function.
guyharris commented 4 months ago

man page, remove ?

Done.

guyharris commented 4 months ago

These changes need an entry in the change log and a note in the "Dependency on libpcap" section of README.md, also possibly in INSTALL.md.

I've done all three.