the-tcpdump-group / tcpslice

tcpslice concatenates multiple pcap files together, or extracts time slices from one or more pcap files.
67 stars 23 forks source link

Avoid casting where possible #20

Closed AreaZR closed 8 months ago

AreaZR commented 1 year ago

We should try to avoid changing the signedness of unsigned variables where possible.

AreaZR commented 1 year ago

@fxlb I fixed the mistake.

fxlb commented 1 year ago

Your title is Prefer unsigned variables where appropiate. Some changes are not related with this title. What are the problems you want to solve?

AreaZR commented 1 year ago

Avoid casting where possible.

AreaZR commented 1 year ago

@fxlb I hope this works for you!

infrastation commented 1 year ago

The commit summary says "avoid casting", but the diff removes two type casts and adds three type casts. This needs to be a bit more focused.

AreaZR commented 1 year ago

@infrastation Done!

AreaZR commented 1 year ago

@fxlb Done!

infrastation commented 8 months ago

As these changes are now, they still replace two type casts with three type casts and make a number of other unrelated changes, so I find it best to reject the proposed changes in order to be able to prioritize more important pending work. Thank you for your time anyway.