Closed AreaZR closed 8 months ago
@fxlb I fixed the mistake.
Your title is Prefer unsigned variables where appropiate
.
Some changes are not related with this title.
What are the problems you want to solve?
Avoid casting where possible.
@fxlb I hope this works for you!
The commit summary says "avoid casting", but the diff removes two type casts and adds three type casts. This needs to be a bit more focused.
@infrastation Done!
@fxlb Done!
As these changes are now, they still replace two type casts with three type casts and make a number of other unrelated changes, so I find it best to reject the proposed changes in order to be able to prioritize more important pending work. Thank you for your time anyway.
We should try to avoid changing the signedness of unsigned variables where possible.