the-teacher / the_sortable_tree

Nested Set + Drag&Drop GUI. Very fast! Best render helper! 2000 nodes/sec. Ready for rails 4
MIT License
558 stars 127 forks source link

Rails 5.1 compatibility #92

Closed vadimstroganov closed 6 years ago

vadimstroganov commented 7 years ago

render(nothing: true) does not work in Rails Version >= 5.1 render(nothing: true) is replaced by the custom handler 'head_respond', which checks the version of Rails and uses the required answer variant (head or render(nothing: true)).

uuushiro commented 7 years ago

When is it merged?

scarroll32 commented 6 years ago

+1

araslanov-e commented 6 years ago

+1 When is it merged?

scarroll32 commented 6 years ago

Rails 5.2 will be released soon.

the-teacher commented 6 years ago

@seanfcarroll @araslanov-e @perlmunger @uuushiro @vadimstroganov I closed my eyes and just pressed the merge button. In case if you have any issue, please, send a PR. I'll try to update the gem on rubygems ASAP.

scarroll32 commented 6 years ago

Hi @the-teacher, I like your style. Perhaps it would help if members of the community using this gem (eg: like myself), could write some tests. Then, as an open source project, you could have a free CI such as Travis.

Thanks for the great gem!

araslanov-e commented 6 years ago

@the-teacher напиши, пожалуйста, когда гем обновишь на rubygems, чтобы сразу обновиться

the-teacher commented 6 years ago

@araslanov-e https://rubygems.org/gems/the_sortable_tree/versions/2.7.0

araslanov-e commented 6 years ago

@the-teacher thanks!

araslanov-e commented 6 years ago

@the-teacher у тебя REAMDE не соответсвует содержимому. Стили и js иначе стали подключаться и именоваться

araslanov-e commented 6 years ago

@the-teacher ты можешь выпустить версию 2.6.2 с поддержкой Rails 5?

araslanov-e commented 6 years ago

))) забыли сделать include DefineDeprecatedMethods

araslanov-e commented 6 years ago

@the-teacher https://github.com/araslanov-e/the_sortable_tree/tree/v2.6.2. Создай ветку, типо v_2_6, я в неё пулл реквест сделаю

the-teacher commented 6 years ago

@araslanov-e https://github.com/the-teacher/the_sortable_tree/tree/v2.6

the-teacher commented 6 years ago

@araslanov-e

Readme будет обновлена позже Readme will be updated a bit later