Rework contribution section

the-teachingRSE-project / competencies

The teachingRSE project: "Teaching and Learning Research Software Engineering"

Creative Commons Attribution 4.0 International

28 stars 19 forks source link

Rework contribution section #350

Closed CaptainSifff closed 3 months ago

CaptainSifff commented 3 months ago

Oh well, I looked into the Credit system again, and I only thought.... Well, how does this fit to us? So I wrote a generic text to tick that box, and went on to detail those parts that I could remember, which you have contributed over the past years. Feel free to raise your opinions.

I also accept private E-Mail, if I took a wrong direction somewhere....

Now comes the pleasure of finding all your github usernames ....

CaptainSifff commented 3 months ago

Pinging @sdruskat , @tobyhodges @annalenalamprecht , @HeidiSeibold , @hvwaldow , @samumantha As I found out there's a limit of 15 reviewers on github....

jngrad commented 3 months ago

I predict there will be a lot of small changes during review. In order to reduce notifications, we could apply suggested changes in batches, i.e. 1 commit for multiple review comments. :wink: This option is only visible in the Changes tab, afaik.

CaptainSifff commented 3 months ago

the spell-checker will be made happy by the PR of @jcohen02 .

annalenalamprecht commented 3 months ago

I cannot find it back right now, but @MakisH pointed out earlier that "helped us" (and similar wording) sounds a bit odd when mentioning people who are also on the list of authors. Simply removing the "us" from these sentences would solve the issue.

Edit: Seeing now that @knarrff was just making changes in this direction. Thanks!!

CaptainSifff commented 3 months ago

I'm beginning the publication process, thereby closing this box as of now.

sdruskat commented 3 months ago

Thanks for the ping, I‘ll get to review this week (before Friday).