search

the-turk / flarum-diff

View post edit histories in your Flarum forum.
https://discuss.flarum.org/d/22779-diff-for-flarum
MIT License
8 stars 6 forks source link

Utilize composer to manage dependancies? #1

Closed jfcherng closed 4 years ago

jfcherng commented 4 years ago

I am not using Flarum but obviously Flarum uses Composer and so does this plugin.

Wouldn't move this to the top level composer.json and remove this and this results in a better dependency management practice? And then you don't have to add vendor/ directory to your repo as well.

I randomly check an official extension, flarum/auth-twitter just uses the standard/common way to manage PHP component dependencies like other PHP applications.

the-turk commented 4 years ago

Yeah it's actually released as work-in-progress, still some issues waiting to be solved: https://discuss.flarum.org/d/22755-mithril-related-issues-on-poststream-items

I didn't announce it to community yet but thanks for the info they probably will be done in 0.1.0-beta.2

jfcherng commented 4 years ago

By the way, since you utilize jfcherng/php-diff 6.4.3 feature/fix, the min version should be ^6.4.3 (not ^6.3).

The dark theme looks really nice. Great work!

the-turk commented 4 years ago

i've just uploaded this version to show Flarum devs actually so they can see what's going on with the source code (mainly the js part of it) 😅 thanks again.

the-turk commented 4 years ago

closing this for now, feel free to re-open when you have any other request when 0.1.0-beta.2 is released.