search

the-useless-one / pywerview

A (partial) Python rewriting of PowerSploit's PowerView
GNU General Public License v3.0
890 stars 113 forks source link

pycrypto module requirement #44

Closed Qazeer closed 3 years ago

Qazeer commented 3 years ago

Hello!

Is the pycrypto module still required (as specified in the install_requires)?

The pycrypto project is no longer maintained and causes issues for standalone build on Windows (due to incompatibility with recent VS build tools).

I haven't seen any usage of pycrypto in the code after a quick glance and it is no longer required by impacket (#485). I removed the requirements and could successfully setup pywerview as well as call a few submodules.

If pycrypto is required, would it be possible to replace it by pycryptodome (a good transparent replacement with the same namespace / functions)?

ThePirateWhoSmellsOfSunflowers commented 3 years ago

Hi! Yes you are right, I think we need to clean up the setup.py file to match requirements.txt. I'll try to fix (and test!) this soon.

:sunflower:

ThePirateWhoSmellsOfSunflowers commented 3 years ago

Hey!

As you probably saw, I pushed a fix for this issue in develop. I'm not familiar with dependency management but I think it's ok now.

:sunflower:

Qazeer commented 3 years ago

Hi!

Thank you 👍

mpgn commented 3 years ago

Hello @ThePirateWhoSmellsOfSunflowers

Can you also push it to master and push it to pip ? This is a blocking point for us to generate the docker image.

Thanks :)

ThePirateWhoSmellsOfSunflowers commented 3 years ago

Salut 😄 !

I'm currently away from keyboard but I'll take a look.

🌻

the-useless-one commented 3 years ago

Hi all! We're back from vacation and we were able to push the new release to PyPI. Hope this helps!

maaaaz commented 1 year ago

In case crypto functions are still needed, use pycryptodome instead of pycrypto.