the-via / app

GNU General Public License v3.0
816 stars 186 forks source link

Encoder-in-matrix "hack" removal notification #155

Open tzarc opened 1 year ago

tzarc commented 1 year ago

Just a heads-up, as per the deprecation policy QMK is going to be removing the "encoder-in-keymatrix" hacks that older boards used pre-encodermap. These are already causing issues with maintenance during refactoring and cleanup, and put simply, have no future within the codebase.

Encoder mapping has been in for several breaking changes cycles now, and new board submissions have already transitioned across to using it.

We'll be doing so on the develop branch shortly after the current breaking change cycle completes, which is intended to occur 2023-05-28. This will give VIA 3 months after that date to handle the conversion of in-matrix encoders to encoder map.

Raising this issue so that you guys have visibility and an appropriate lead time to make whatever changes VIA requires on your end.

adophoxia commented 1 year ago

Decided to raise a draft up a PR over in the-via/keyboards repo pertaining to this issue.