the-via / app

GNU General Public License v3.0
764 stars 173 forks source link

Disabling RGB Matrix effect on QMK skews VIA's effect list #178

Open sheosi opened 1 year ago

sheosi commented 1 year ago

Hi! First, thanks for giving us VIA! I'be playing with it and in trying to squeeze out the progam size I've been removing matrix effects, but it turns out via is not aware of this and uses the same code underneath since the list ends up being skewed from the point where the effect was onward.

Would it be possible for it to deactivate the effects that don't exist?

wilba commented 1 year ago

You need to define the custom menus explicitly, instead of using the "built-in" one for the default RGB Matrix.

See here: https://www.caniusevia.com/docs/custom_ui

Copy the RGB Matrix one here:

https://www.caniusevia.com/docs/built_in_menus#qmk_rgb_matrix

into the VIA definition, and then edit the list to match the enabled effects.

sheosi commented 1 year ago

Thanks, that worked perfectly! The step that was a little unclear though was on were to obtain the original JSON in order to modify it, maybe include a small note saying where they can be found.