search

the-via / app

GNU General Public License v3.0
921 stars 209 forks source link

[Question] somehow the app tries to fetch v2 definition instead of v3 and got 404 #184

Closed tan-t closed 1 year ago

tan-t commented 1 year ago

Hi. I'm kinda new here, if anything wrong please let me know.

what is happening

I'm working on my new keyboard which is named MOTHWING, my PR was successfully merged today but I'm seeing some error which says Fetching v2 definition failed.

what I tried

I looked into the chrome devtool's network tab, it says that the app requested to https://usevia.app/definitions/v2/1299644417.json and got 404.
Actually my PR didn't include V2 definition (the way which I had been suggested), and I'm sure that definitions/v2/ URL won't work.
when I manually accesed to https://usevia.app/definitions/v3/1299644417.json then it returns a normal definition layout json.

I thought that maybe something is wrong so the app tries to fetch v2 definition, and I should sort that out, but I have no idea.
it doesn't look that the app initially fetched V3 definition then tried to fall back to V3, so the V3 definition itself does not seem to be related to this behavior.
I doubt that the firmware is kind of out-of-date? but I don't think the spec diferrence between V2 and V3 is firmware-related one(it is for the customizing UI isn't it?)

anyone knows what to do?
thanks in advance!

tan-t commented 1 year ago

https://github.com/the-via/app/blob/bae0a0f302af525842e209f5af490959b955bb73/src/store/devicesThunks.ts#L166
I see, the app extracts protocol version from the firmware and it automatically judges which version to fetch.
my bad. closing it