search

the-via / app

GNU General Public License v3.0
765 stars 173 forks source link

Show tooltips for keys with a shortName #188

Open kyleshay opened 11 months ago

kyleshay commented 11 months ago

Hi! This diff is just a suggestion, feel free to close if you like.

I noticed that tooltips are only being shown today, but only sometimes — for example, if a key name doesn't fit within the key cap.

It's not always intuitive (for a beginner like myself) to know what all of the short hand names map to.

This diff just always shows tooltips for items that have a shortName specified in src/utils/key.ts. It's a bit weird because it's kind of a side-effect of having a shortName specified, but in turn it makes things a bit easier for when you're hovering over caps.

There's ~318 keys in src/utils/key.ts and 44 of them specify a shortName.

image

kyleshay commented 11 months ago

I just came across #175/#105 — I guess we'd need to coordinate on what's desired here. That PR ends up effectively doing the same (but ends up making every single key have a tooltip.)

Maybe it ends up being something similar to the little bar that's shown on hover in the key list frame so you're not spammed w/ tooltips, eg:

Screenshot by Dropbox Capture