search

the-via / app

GNU General Public License v3.0
917 stars 209 forks source link

Bug: unable to save layout in Brave #242

Open delasource opened 7 months ago

delasource commented 7 months ago

Clicking "Save" does nothing at my side. It shows in console log "User cancelled save file request" but i didnt. Using Brave, tried with all blockers disabled. Using Edge or Chrome, it is working.

bboc commented 6 months ago

Same issue here, tested on Brave version 1.65.130 on MacOs Sonoma, with a new profile, default settings, no extensions, and all shields disabled. Load button appears to work,though, clicking it displays a dialog for selecting a file.

potter-man commented 6 months ago

Somehow there is no Window::showSaveFilePicker function in Brave Issue: https://github.com/brave/brave-browser/issues/29411

It enables with flag File System Access API mentioned in the comment https://github.com/brave/brave-browser/issues/29411#issuecomment-1534565893

bboc commented 6 months ago

@potter-man Thanks. I can confirm that enabling the flag opens the download dialog.

I guess we can't expect all Brave users to enable that flag, so the simplest fix I can imagine is testing for Window::showSaveFilePicker, and if that does not exist, simply trigger a download with a default filename.