the-via / app

GNU General Public License v3.0
803 stars 182 forks source link

Feature request: Hex color input next to picker #90

Open karlshea opened 1 year ago

karlshea commented 1 year ago

Every time I flash my firmware I lose all of my lighting settings. This isn't a huge issue except for the color pickers: it's extremely difficult to figure out what the RGB value is currently set to (although a bit easier if running in a browser because I can inspect the color tile), and even harder to set it back to what it was.

If there was a text input that showed the current RGB hex values that would make it super simple to back up and restore those colors with just some copy & pasting.

Thanks!

iMobs commented 1 year ago

I'm taking a look at the ColorPicker component and wondering why not just use the native <input type="color" /> which would greatly simplify things and allow for setting the RGB, HSL, or hex values. Right now there's a whole lot of unnecessary math around mouse position within a div to determine the hue and saturation. There are also a ton of helpers for converting HSV colors to RGB and back that I suggest be replaced with a library like colord.

Another alternative is react-color for some predefined looks.