the-via / releases

GNU General Public License v3.0
2.08k stars 223 forks source link

Add TD() to the list #37

Open jkutianski opened 4 years ago

jkutianski commented 4 years ago

I've Tap Dance configured on my keyboard and I've to use keycodes of this. If is posible use TD(nn) instead of 0x57nn will be nice.

https://github.com/jkutianski/qmk_compaq_mx-11800/blob/master/keymaps/via/keymap.c

VIA

nathish commented 4 years ago

@jkutianski have you got any further with this? I'm trying to configure tap dance as well. Do you have it working?

Not sure what you mean when you say "instead of 0x57nn". Can you explain?

jkutianski commented 4 years ago

The tap dance definitions need to be on your keyboard. Like this.

qk_tap_dance_action_t tap_dance_actions[] = {
    // Keypad tap dance keys
    [0] = ACTION_TAP_DANCE_DOUBLE(KC_NLCK, KC_CALC),  // 0x5700
    [1] = ACTION_TAP_DANCE_DOUBLE(KC_PENT, KC_TAB),   // 0x5701
    [2] = ACTION_TAP_DANCE_DOUBLE(KC_PDOT, KC_COMM),  // 0x5702
}

After that you can assign the tap dance action using ANY and the keycode corresponding to the tap dance action (starting at 0x5700)

Check my keymap to see how to do it. https://github.com/jkutianski/qmk_compaq_mx-11800/blob/master/keymaps/via/keymap.c

nathish commented 4 years ago

@jkutianski thanks

+1 for using the key codes instead of 0x57nn